Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset_select_paginated: do not clone on each paginated query #629

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

skshetry
Copy link
Member

Let's see if the test passes.

Context: #521 (comment).

@skshetry skshetry requested a review from a team November 26, 2024 03:50
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2af2d9c
Status: ✅  Deploy successful!
Preview URL: https://c92e9310.datachain-documentation.pages.dev
Branch Preview URL: https://clone-once.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (853a58c) to head (2af2d9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/data_storage/warehouse.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files         106      106           
  Lines       10292    10292           
  Branches     1386     1386           
=======================================
  Hits         9021     9021           
  Misses        929      929           
  Partials      342      342           
Flag Coverage Δ
datachain 87.59% <93.75%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding 🔥 Thank you! 👍

@skshetry skshetry merged commit fb58381 into main Nov 26, 2024
38 checks passed
@skshetry skshetry deleted the clone-once branch November 26, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants