Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused _parse_datasets method from abstract db metastore #643

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

mattseddon
Copy link
Member

missed in #634

@mattseddon mattseddon self-assigned this Nov 28, 2024
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: e0dfc92
Status: ✅  Deploy successful!
Preview URL: https://46d64d03.datachain-documentation.pages.dev
Branch Preview URL: https://remove-dead-method.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (3bd22ad) to head (e0dfc92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   87.70%   87.73%   +0.03%     
==========================================
  Files         112      112              
  Lines       10672    10667       -5     
  Branches     1437     1435       -2     
==========================================
- Hits         9360     9359       -1     
+ Misses        954      950       -4     
  Partials      358      358              
Flag Coverage Δ
datachain 87.68% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon marked this pull request as ready for review November 28, 2024 23:42
@mattseddon mattseddon requested a review from a team November 28, 2024 23:43
0x2b3bfa0

This comment was marked as outdated.

@mattseddon mattseddon merged commit 049f718 into main Nov 29, 2024
38 checks passed
@mattseddon mattseddon deleted the remove-dead-method branch November 29, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants