-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow testing external contributions using secrets #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HF_TOKEN
on external contributions
Deploying datachain-documentation with
|
Latest commit: |
3ce0369
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1aea2b15.datachain-documentation.pages.dev |
Branch Preview URL: | https://0x2b3bfa0-patch-1.datachain-documentation.pages.dev |
for more information, see https://pre-commit.ci
0x2b3bfa0
commented
Dec 6, 2024
shcheklein
approved these changes
Dec 6, 2024
dreadatour
approved these changes
Dec 7, 2024
ilongin
approved these changes
Dec 9, 2024
Disabling the test for external contributions could have been easier fix here than using |
Quoting myself again:
If we don't expect external contributors to modify parts of the code that need to be tested against external services, indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delightful self-plagiarism from https://datachain.ai/blog/testing-external-contributions-using-github-actions-secrets