Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing external contributions using secrets #667

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Dec 6, 2024

@0x2b3bfa0 0x2b3bfa0 added the tests label Dec 6, 2024
@0x2b3bfa0 0x2b3bfa0 requested a review from a team December 6, 2024 15:04
@0x2b3bfa0 0x2b3bfa0 self-assigned this Dec 6, 2024
@0x2b3bfa0 0x2b3bfa0 changed the title Allow testing with HF_TOKEN on external contributions Allow testing external contributions using secrets Dec 6, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 6, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ce0369
Status: ✅  Deploy successful!
Preview URL: https://1aea2b15.datachain-documentation.pages.dev
Branch Preview URL: https://0x2b3bfa0-patch-1.datachain-documentation.pages.dev

View logs

@0x2b3bfa0 0x2b3bfa0 merged commit 2954ce5 into main Dec 9, 2024
9 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch December 9, 2024 08:45
@skshetry
Copy link
Member

skshetry commented Dec 9, 2024

Disabling the test for external contributions could have been easier fix here than using pull_request_target.

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Dec 9, 2024

Quoting myself again:

Other common alternatives include: skipping tests that need access to secrets [...]

If we don't expect external contributors to modify parts of the code that need to be tested against external services, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants