-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log streaming to the created job #680
Conversation
When running a job from studio, this adds a log streaming which checks for the updates from the Studio. Relate PR: iterative/studio#11068
Deploying datachain-documentation with Cloudflare Pages
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
- Coverage 87.44% 87.38% -0.07%
==========================================
Files 114 114
Lines 10898 10939 +41
Branches 1499 1506 +7
==========================================
+ Hits 9530 9559 +29
- Misses 990 999 +9
- Partials 378 381 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for this update 🥰
Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not sure WebSockets are a good idea, especially for log streaming. I'm not even talking about SSE here, but even about plain old polling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but I wonder if it should be closer to real-time; the following example seems to be buffering the whole output and takes ages to print the logs: 🧐
datachain studio run test.py
import time
for number in range(60 * 60):
time.sleep(0.1)
print(number)
Found an possible cause in Studio side. Working on it alongside the test cases for this. |
When running a job from studio, this adds a log streaming which checks
for the updates from the Studio.
Related PR: https://github.com/iterative/studio/pull/11068