Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making cp as non default when pulling dataset #720

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Dec 17, 2024

Replacing no_cp with cp argument in Catalog.pull_dataset() and setting it to False, meaning we won't cp / instantiate dataset files when pulling it from Studio. If use want's to do instantiation, it needs to explicitly set cp flag to True now.

@ilongin ilongin linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.41%. Comparing base (bdcd01b) to head (f338a8d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/catalog/catalog.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   87.44%   87.41%   -0.03%     
==========================================
  Files         114      114              
  Lines       10898    10898              
  Branches     1499     1499              
==========================================
- Hits         9530     9527       -3     
- Misses        990      992       +2     
- Partials      378      379       +1     
Flag Coverage Δ
datachain 87.35% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilongin ilongin merged commit 10e90c5 into main Dec 17, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cp not default on datachain pull
2 participants