Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more generalize SignalsSchema.;get_signals() method instead of get_file_signals(...) #86

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Jul 18, 2024

Adding more generalize method that can be used to get different types of signals, not just files.

Also removed not used DataChain.get_file_signals(...)

Fixes https://github.com/iterative/dvcx/issues/1711

@ilongin ilongin marked this pull request as draft July 18, 2024 16:28
Copy link

cloudflare-workers-and-pages bot commented Jul 18, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1da7000
Status: ✅  Deploy successful!
Preview URL: https://c275464d.datachain-documentation.pages.dev
Branch Preview URL: https://ilongin-1711-implement-get-s.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (e8eabfd) to head (1da7000).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   84.47%   84.48%           
=======================================
  Files          95       95           
  Lines        9523     9522    -1     
  Branches     1885     1885           
=======================================
  Hits         8045     8045           
+ Misses       1150     1149    -1     
  Partials      328      328           
Flag Coverage Δ
datachain 84.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ilongin ilongin marked this pull request as ready for review July 19, 2024 07:15
@ilongin ilongin merged commit 4bf55ac into main Jul 19, 2024
19 checks passed
@ilongin ilongin deleted the ilongin/1711-implement-get-signals branch July 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants