Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UDF to UDFStep for clarity, and remove from root namespace #88

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

rlamy
Copy link
Contributor

@rlamy rlamy commented Jul 18, 2024

Follow-up to #23

@rlamy rlamy requested review from dtulga and mattseddon July 18, 2024 18:18
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: e751d18
Status: ✅  Deploy successful!
Preview URL: https://113a2908.datachain-documentation.pages.dev
Branch Preview URL: https://hide-udf-step.datachain-documentation.pages.dev

View logs

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (e05463f) to head (e751d18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   84.46%   84.45%   -0.01%     
==========================================
  Files          94       94              
  Lines        9511     9510       -1     
  Branches     1883     1883              
==========================================
- Hits         8033     8032       -1     
  Misses       1150     1150              
  Partials      328      328              
Flag Coverage Δ
datachain 84.39% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rlamy rlamy merged commit d244943 into main Jul 18, 2024
19 checks passed
@rlamy rlamy deleted the hide-udf-step branch July 18, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants