fix(cli, studio): don't retry on non request/http errors #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 130 130
Lines 11661 11665 +4
Branches 1586 1586
=======================================
+ Hits 10226 10230 +4
Misses 1038 1038
Partials 397 397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0x2b3bfa0
approved these changes
Feb 8, 2025
shcheklein
force-pushed
the
fix/cli-hangs-on-get-team-exception-retries
branch
from
dede005 to
7acb0f7
Compare
Deploying datachain-documentation with
|
| Latest commit: |
7acb0f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16cfc44e.datachain-documentation.pages.dev |
| Branch Preview URL: | https://fix-cli-hangs-on-get-team-ex.datachain-documentation.pages.dev |
shcheklein
commented
Feb 8, 2025
| def _send_request( | ||
| self, route: str, data: dict[str, Any], method: Optional[str] = "POST" | ||
| ) -> Response[Any]: | ||
| """ | ||
| Function that communicate Studio API. | ||
| It will raise an exception, and try to retry, if 5xx status code is | ||
| returned, or if ConnectionError or Timeout exceptions are thrown from | ||
| requests lib | ||
| returned, or if Timeout exceptions is thrown from the requests lib |
There was a problem hiding this comment.
[C]: removed ConnectionError from the one we retry on. It is usually Proxy, or something SSL - don't think we can recover from those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W/o this fix, if team is not set via env variable
DVC_STUDIO_TEAMand / or DataChain config,self.teamin Studio remote client raises aDataChainError(which is fine). What is not fine is that_send_requestkeeps retying with an exponential backoff on those.Pretty much means that first time someone is trying to run something like
datachain ds pull ...there are big chances to hit a long hang w/o any messages at all. Then if you are like to wait you can see that it just expect team to be set.Also improves the messaging around
get_teamerrors a bit.TODO: