Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not overwrite version with None in DatasetQuery constructor #92

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mattseddon
Copy link
Member

Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6521b5b
Status: ✅  Deploy successful!
Preview URL: https://66f4d751.datachain-documentation.pages.dev
Branch Preview URL: https://fix-from-dataset-version.datachain-documentation.pages.dev

View logs

@mattseddon mattseddon force-pushed the fix-from-dataset-version branch from 86e3caa to ccfed51 Compare July 19, 2024 01:10
@mattseddon mattseddon self-assigned this Jul 19, 2024

dc = DataChain.from_dataset(name)
assert dc.name == name
assert dc.version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert dc.version
assert dc.version == 1

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (4e25c9a) to head (6521b5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   84.47%   84.46%   -0.01%     
==========================================
  Files          95       95              
  Lines        9524     9523       -1     
  Branches     1885     1885              
==========================================
- Hits         8045     8044       -1     
  Misses       1151     1151              
  Partials      328      328              
Flag Coverage Δ
datachain 84.40% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon force-pushed the fix-from-dataset-version branch from ccfed51 to f4f97ce Compare July 19, 2024 02:13
@mattseddon mattseddon force-pushed the fix-from-dataset-version branch from f4f97ce to 6521b5b Compare July 19, 2024 02:23
@mattseddon mattseddon marked this pull request as ready for review July 19, 2024 02:24
@mattseddon mattseddon merged commit e8eabfd into main Jul 19, 2024
19 checks passed
@mattseddon mattseddon deleted the fix-from-dataset-version branch July 19, 2024 02:51
@skshetry
Copy link
Member

Hey, please respond to comments/posts before merging. It's okay if you disagree with the suggestions, in fact I am okay even without that. But please do respond. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants