-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not overwrite version with None in DatasetQuery constructor #92
Conversation
Deploying datachain-documentation with Cloudflare Pages
|
86e3caa
to
ccfed51
Compare
|
||
dc = DataChain.from_dataset(name) | ||
assert dc.name == name | ||
assert dc.version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert dc.version | |
assert dc.version == 1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 84.47% 84.46% -0.01%
==========================================
Files 95 95
Lines 9524 9523 -1
Branches 1885 1885
==========================================
- Hits 8045 8044 -1
Misses 1151 1151
Partials 328 328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ccfed51
to
f4f97ce
Compare
f4f97ce
to
6521b5b
Compare
Hey, please respond to comments/posts before merging. It's okay if you disagree with the suggestions, in fact I am okay even without that. But please do respond. 🙂 |
Closes https://github.com/iterative/dvcx/issues/1656