Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashfile.checkout: use multiprocessing.Pool to checkout concurrently #547

Closed
wants to merge 1 commit into from

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Aug 8, 2024

No description provided.

@dberenbaum
Copy link

Did you try it with threads but found it faster with multiprocessing and batches? It's not obvious to me which would be better here. Otherwise LGTM.

@skshetry
Copy link
Member Author

skshetry commented Aug 9, 2024

Did you try it with threads but found it faster with multiprocessing and batches? It's not obvious to me which would be better here. Otherwise LGTM.

On my linux machine, threadpoolexecutor was slower than sequential operation. So I used multiprocessing. But mp has overhead, so I had to resort to use batches to reduce the overhead.

It's interesting to see that M1 has fast computation, but slower filesystem. But for me, filesystem operations are quite fast, but computation is the bottleneck. (Linux prob. has low overhead on system calls, and maybe Linux's direntry cache is helping here).

@skshetry skshetry closed this Aug 19, 2024
@skshetry skshetry deleted the hashfile/checkout-mPool branch August 19, 2024 09:49
@dberenbaum
Copy link

@skshetry Why close this one?

@skshetry
Copy link
Member Author

It's not clear to me how much improvement this makes, compared to the complexity it introduces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants