Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skips #1

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix skips #1

merged 2 commits into from
May 6, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 4, 2022

No description provided.

Copy link
Contributor Author

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_import_dir fails because of how FakeHadoopFS resolves the path in:

def _adjust_entry(self, entry):
import posixpath
from pyarrow.fs import FileInfo
mocked_path = os.path.relpath(entry.path, self._root)
mocked_parts = mocked_path.split(os.path.sep)
return FileInfo(
path=posixpath.join(*mocked_parts),
type=entry.type,
mtime=entry.mtime,
size=entry.size,
)

@efiop Is there a reason for not using actual HadoopFS (installation issues?) . Using the fake fs also hid the bug in iterative/dvc#7563

@daavoo daavoo requested a review from efiop May 4, 2022 15:59
@efiop
Copy link
Contributor

efiop commented May 4, 2022

@daavoo real hdfs takes a while to install and doesn't work anywhere except for linux (mac runners don't have docker). Seems like iterative/dvc#7563 should be tested with a unit test.

@daavoo daavoo mentioned this pull request May 4, 2022
@daavoo daavoo merged commit a4b4384 into main May 6, 2022
@daavoo daavoo deleted the fix-skips branch May 6, 2022 07:35
@efiop efiop added the bug Something isn't working label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants