Skip to content

Commit

Permalink
drop safety (#295)
Browse files Browse the repository at this point in the history
GitHub has dependency alerts and dependency security updates
that can replace `safety`.

For the past few months, safety has been raising vulnerability
errors for `pip` and now `jinja2`. The latter is a dependency
of `safety` itself, and both CVEs are disputed.

Which is breaking CI for us.
  • Loading branch information
skshetry authored Jun 15, 2024
1 parent 8ff6a55 commit fe4c7a0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
pip --version
nox --version
- name: Lint code and check dependencies
run: nox -s lint safety
- name: Lint code
run: nox -s lint

- name: Run tests
run: nox -s tests-${{ matrix.nox_pyv || matrix.pyv }} -- --cov-report=xml
Expand Down
8 changes: 0 additions & 8 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,6 @@ def lint(session: nox.Session) -> None:
session.run("python", "-m", "mypy")


@nox.session
def safety(session: nox.Session) -> None:
"""Scan dependencies for insecure packages."""
session.install(".[dev]", *pip_dev_flags)
session.install("safety")
session.run("safety", "check", "--full-report")


@nox.session
def build(session: nox.Session) -> None:
session.install("build", "setuptools", "twine")
Expand Down

0 comments on commit fe4c7a0

Please sign in to comment.