Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: use .pytest_cache as tmpdir for running benchmarks #242

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Dec 6, 2023

This makes it possible to test Linux where tmpdir is using tmpfs rather than the filesystem that supports reflink.

Also we run test for 1000 links, but run 10 rounds (with 3 warmup rounds) for better results, as a single test may be noisy.

This makes it possible to test Linux where tmpdir is using tmpfs
rather than the filesystem that supports reflink.

Also we run test for 1000 links, but run 10 rounds (with 3 warmup rounds)
for better results, as a single test may be noisy.
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (da02e76) 64.26% compared to head (8fe9763) 64.47%.

Files Patch % Lines
tests/benchmarks/test_fs.py 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   64.26%   64.47%   +0.21%     
==========================================
  Files          27       27              
  Lines        2040     2041       +1     
  Branches      323      324       +1     
==========================================
+ Hits         1311     1316       +5     
+ Misses        669      664       -5     
- Partials       60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit eceb8c5 into main Dec 6, 2023
13 checks passed
@skshetry skshetry deleted the benchmark-tests branch December 6, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants