fs: replace fs.path with plain fs methods #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After such a long time using it, it is clear that it wasn't the right decision and path manipulation methods should be right in the class. This also makes it possible to use most of methods as classmethods without having to initialize the filesystem at all. Per fsspec/filesystem_spec#747 (comment) and also a pre-requisite for it.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 64.16% 64.35% +0.19%
==========================================
Files 27 26 -1
Lines 2051 2051
Branches 321 335 +14
==========================================
+ Hits 1316 1320 +4
+ Misses 675 672 -3
+ Partials 60 59 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After such a long time using it, it is clear that it wasn't the right decision and path manipulation methods should be right in the class. For now just moving things as they were, but might rethink particular implementations later.
This also makes it possible to use most of methods as classmethods without having to initialize the filesystem at all.
Per fsspec/filesystem_spec#747 (comment) and also a pre-requisite for it.