use token_urlsafe instead of shortuuid to generate temp file #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python>=3.6 has secrets.token_urlsafe that can create cryptographically safe strings/numbers. So we don't need to use shortuuid. The generated text string is of the same size as `shortuuid.uuid()`, but can contain underscore and hyphen characters (not just alpha-numeric values), which might make it less human-readable. But I am not sure if it's worth it to use a third-party library (which can be gradually removed).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 63.37% 63.35% -0.02%
==========================================
Files 26 26
Lines 2105 2104 -1
Branches 336 336
==========================================
- Hits 1334 1333 -1
Misses 720 720
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python>=3.6 has
secrets.token_urlsafethat can create cryptographically safe strings/numbers. So we don't need to use shortuuid. The generated text string is of the same size asshortuuid.uuid(), but can contain underscore and hyphen characters (not just alpha-numeric values), which might make it less human-readable. But I am not sure if it's worth it to use a third-party library (which can be gradually removed).token_urlsafeis also 4x faster thanshortuuid.uuid().