gha: fix issue when caching virtual environments #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the `setup-python` action would provide a new patch version of the python (as it happened with 3.10.4 -> 3.10.5), it'd break the caching of the virtual environment in the nox and would throw following (cryptic) error: ``` Error: python is not installed into the virtualenv, it is located at /opt/hostedtoolcache/Python/3.10.5/x64/bin/python. Pass external=True into run() to explicitly allow this. ``` It seems it's because the virtualenv has a broken symlink to the old interpreter that does not exist after the update. actions/setup-python#182 may be related. With this change, the cache key now depends on the full python version instead of just major.minor. So this issue should hopefully not happen again, and automatically get invalidated.
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 45.44% 44.68% -0.76%
==========================================
Files 34 34
Lines 2007 2003 -4
Branches 238 213 -25
==========================================
- Hits 912 895 -17
- Misses 1077 1092 +15
+ Partials 18 16 -2
Continue to review full report at Codecov.
|
|
Great research! Thank you, @skshetry ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the
setup-pythonaction would provide a new patch version of the python (as it happened with 3.10.4 -> 3.10.5), it'd break the caching of the virtual environment in the nox and would throw following (cryptic) error:It seems it's because the virtualenv has a broken symlink to the old interpreter that does not exist after the update.
actions/setup-python#182 may be related.
With this change, the cache key now depends on the full python version instead of just major.minor. So this issue should hopefully not happen again, and automatically get invalidated.
Also see 855ea68, d4482b7 and d6606c9.