Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obj: add __slots__ #63

Merged
merged 1 commit into from
Jun 20, 2022
Merged

obj: add __slots__ #63

merged 1 commit into from
Jun 20, 2022

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jun 20, 2022

We are creating lots of these, so it will help to save up on memory and
improve performance.

Similar to iterative/dvc-data#56

We are creating lots of these, so it will help to save up on memory and
improve performance.

Similar to iterative/dvc-data#56
@codecov-commenter
Copy link

Codecov Report

Merging #63 (e99703b) into main (c7d7b4b) will decrease coverage by 0.78%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   45.44%   44.66%   -0.79%     
==========================================
  Files          34       34              
  Lines        2007     2004       -3     
  Branches      238      213      -25     
==========================================
- Hits          912      895      -17     
- Misses       1077     1093      +16     
+ Partials       18       16       -2     
Impacted Files Coverage Δ
src/dvc_objects/obj.py 0.00% <0.00%> (ø)
src/dvc_objects/fs/system.py 60.29% <0.00%> (-23.53%) ⬇️
src/dvc_objects/fs/utils.py 41.48% <0.00%> (-0.44%) ⬇️
src/dvc_objects/fs/path.py 0.00% <0.00%> (ø)
src/dvc_objects/executors.py 31.11% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d7b4b...e99703b. Read the comment docs.

@efiop efiop merged commit b2f479d into iterative:main Jun 20, 2022
efiop added a commit to efiop/dvc-data that referenced this pull request Jun 20, 2022
efiop added a commit to efiop/dvc-data that referenced this pull request Jun 20, 2022
efiop added a commit to iterative/dvc-data that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants