ObjectFileSystem: remove special treatment for empty objects #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dir/` s3/etc objects are really just files with invalid names and instead of giving them special treatment in the filesystem itself, we can simply ignore them while collecting.
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 65.78% 65.32% -0.47%
==========================================
Files 39 39
Lines 2426 2411 -15
Branches 379 378 -1
==========================================
- Hits 1596 1575 -21
- Misses 801 808 +7
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dir/s3/etc objects are really just files with invalid names and instead ofgiving them special treatment in the filesystem itself, we can simply ignore
them while collecting.