-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deb: fix openssl errors #32
Conversation
|
||
def get_pkg_build_cmd(self) -> List[str]: | ||
if self.pkg == "deb": | ||
# this is where pip is installed when running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the default pip
version on ubuntu results in a missing boto3
dependency (might be related to iterative/dvc#7257 ?), but running pip install -U pip
installs pip in /usr/local/bin/pip
|
||
|
||
|
||
FROM base as upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had to be split, since boto3
installed with pip (dvc
dependency) conflicts with boto
import shutil | ||
|
||
import git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just black formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙏
For the record: all of this was caused by |
@dtrifiro Does upgrading to 4.8 fix it? Any traces of anything similar in pyinstaller repo? If not, should we report it in case there is something more serious going on? |
4.8 is still broken when building on CentOS. I'm still trying to trace the source of the issue. One of the differences between the 2.8.3 and 2.9.3 builds is the pygit2 version (1.7.0 vs 1.7.2) |
Fixes iterative/dvc#7207
CA certificates were being searched in
/etc/pki/tls/
, which is where they are stored in centos 7:This could have been due to the fact that the deb package was being built on Centos.
By building the image on ubuntu, the problem is solved.
A workaround for existing installations is to copy (or symlink) an existing ca cert bundle to
/etc/pki/tls/
for example: