Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb: fix openssl errors #32

Merged
merged 2 commits into from
Jan 13, 2022
Merged

deb: fix openssl errors #32

merged 2 commits into from
Jan 13, 2022

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jan 13, 2022

Fixes iterative/dvc#7207

CA certificates were being searched in /etc/pki/tls/, which is where they are stored in centos 7:

[root@centos7 ~] $ find /etc/pki/tls/certs
/etc/pki/tls/certs
/etc/pki/tls/certs/ca-bundle.crt
/etc/pki/tls/certs/ca-bundle.trust.crt
/etc/pki/tls/certs/Makefile
/etc/pki/tls/certs/make-dummy-cert
/etc/pki/tls/certs/renew-dummy-cert

This could have been due to the fact that the deb package was being built on Centos.
By building the image on ubuntu, the problem is solved.

A workaround for existing installations is to copy (or symlink) an existing ca cert bundle to /etc/pki/tls/ for example:

sudo mkdir -p /etc/pki/tls 
sudo ln -s /etc/ssl/certs/ca-certificates.crt /etc/pki/tls/cert.pem

@dtrifiro dtrifiro requested a review from efiop January 13, 2022 19:10
@efiop efiop changed the title Fix/7207 deb pkg openssl errors deb: fix openssl errors Jan 13, 2022

def get_pkg_build_cmd(self) -> List[str]:
if self.pkg == "deb":
# this is where pip is installed when running
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the default pip version on ubuntu results in a missing boto3 dependency (might be related to iterative/dvc#7257 ?), but running pip install -U pip installs pip in /usr/local/bin/pip




FROM base as upload
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had to be split, since boto3 installed with pip (dvc dependency) conflicts with boto

import shutil

import git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just black formatting

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@efiop efiop merged commit 34af969 into master Jan 13, 2022
@dtrifiro
Copy link
Contributor Author

For the record: all of this was caused by 1af23f32 (upgrade from pyinstaller 4.6 to 4.7, iterative/dvc#6960)

@efiop
Copy link
Contributor

efiop commented Jan 13, 2022

@dtrifiro Does upgrading to 4.8 fix it? Any traces of anything similar in pyinstaller repo? If not, should we report it in case there is something more serious going on?

@skshetry skshetry deleted the fix/7207-deb-pkg-openssl-errors branch January 14, 2022 02:58
@dtrifiro
Copy link
Contributor Author

4.8 is still broken when building on CentOS. I'm still trying to trace the source of the issue.

One of the differences between the 2.8.3 and 2.9.3 builds is the pygit2 version (1.7.0 vs 1.7.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc 2.9.x installed from deb package throws pygit OpenSSL errors
2 participants