Restyle S3 access_key_id & secret_access_key args #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
jorgeorpinel
approved these changes
Jul 20, 2020
shcheklein
reviewed
Jul 20, 2020
| `secret_access_key`) instead of `credentialpath`: | ||
|
|
||
| ```dvc | ||
| $ dvc remote modify myremote access_key_id my-access-key-id |
There was a problem hiding this comment.
it's better to use --local as we do for HTTP for example to emphasize that these secrets should never go into Git
There was a problem hiding this comment.
looks like some other remotes should be fixed as well
There was a problem hiding this comment.
OK. Updating in #1607
jorgeorpinel
added a commit
that referenced
this pull request
Jul 21, 2020
shcheklein
pushed a commit
that referenced
this pull request
Jul 22, 2020
* cmd: update remote modify with --local as needed per #1603 (review) * cmd: remove some --local instances from remote modify per #1607 (review) * cmd: remove --local from some remote modify examples per #1607 (comment) * cmd: remove another --local from remote modify per #1607 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #1589 with additional commits that automatically address
incorrect style, created by Restyled.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.