Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: document --targets option #2031

Merged
merged 3 commits into from
Dec 21, 2020
Merged

params: document --targets option #2031

merged 3 commits into from
Dec 21, 2020

Conversation

pared
Copy link
Contributor

@pared pared commented Dec 18, 2020

Related to iterative/dvc#4446 and iterative/dvc#5122.

Introduce description for new params option: --targets.

@pared pared requested a review from jorgeorpinel December 18, 2020 12:26
@shcheklein shcheklein temporarily deployed to dvc-landing-4446-params-mrukze December 18, 2020 12:26 Inactive
@pared pared force-pushed the 4446_params_targets branch from 7692902 to e86eb11 Compare December 18, 2020 12:27
@shcheklein shcheklein temporarily deployed to dvc-landing-4446-params-mrukze December 18, 2020 12:28 Inactive
@jorgeorpinel jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Dec 19, 2020
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein merged commit bdbc21d into master Dec 21, 2020
@shcheklein shcheklein temporarily deployed to dvc-landing-4446-params-mrukze December 21, 2020 20:21 Inactive
@jorgeorpinel
Copy link
Contributor

Hey @pared will iterative/dvc/pull/5122 be part of 1.x or 2.x? To know whether to put this in our v1 branch too or not. Thanks

@shcheklein
Copy link
Member

@jorgeorpinel we have to track, ask the team about the backport PRs and do backport on the DVC.org end accordingly. They are designated as far as I know with a label?

@jorgeorpinel
Copy link
Contributor

OK. There's no special labels in iterative/dvc/issues/4446 or iterative/dvc/pull/5122 though. And that PR isn't merged yet.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Dec 21, 2020

There's no special labels in iterative/dvc/issues/4446 or iterative/dvc/pull/5122

So I will assume that this is NOT 2.0 and can go into our v1 branch (well, #2042 to be precise).

@jorgeorpinel
Copy link
Contributor

✔️ Backported to v1 in 28f46ee.

@shcheklein shcheklein deleted the 4446_params_targets branch February 28, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ status: wait-core-merge Waiting for related product PR merge/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants