Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. updates #2182

Merged
merged 10 commits into from
Mar 3, 2021
Merged

Misc. updates #2182

merged 10 commits into from
Mar 3, 2021

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 11, 2021

Probably see #2154 first.

@shcheklein shcheklein temporarily deployed to dvc-landing-jorge-9uuzm04bjqtr February 11, 2021 17:47 Inactive
@jorgeorpinel jorgeorpinel changed the title term typo Misc. updates Feb 11, 2021
@@ -500,7 +505,8 @@ more information.
### Click for SSH

- `url` - remote location, in a regular
[SSH format](https://tools.ietf.org/id/draft-salowey-secsh-uri-00.html#sshsyntax):
[SSH format](https://tools.ietf.org/id/draft-salowey-secsh-uri-00.html#sshsyntax).
Note that this can already the `user` parameter, embedded into the URL:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can already the - something is missing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, "included". Thanks

@@ -88,7 +91,7 @@ $ dvc run -n download_file \
$ dvc run -n download_file \
-d ssh://user@example.com/path/to/data.txt \
-o data.txt \
scp user@example.com:/path/to/data.txt data.txt
scp ssh://user@example.com:/path/to/data.txt data.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I don't usually specify the protocol like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Reverting this change.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor questions, typos

@jorgeorpinel jorgeorpinel merged commit dafbc44 into master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants