-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: improve add/import* to-cache/remote info and examples #2302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one Q on a fix to the import
ref. Cc @efiop in case you're around (I'll double check this myself tmr if not so no worries). Thanks
(ℹ️) DVC won't push or pull imported data to/from | ||
[remote storage](/doc/command-reference/remote), it will rely on it's original | ||
source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong right? import-url
states the opposite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import
and import-url
have different behavior, the original docs for each command were correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestinggggg 🤔 OK will roll back, thanks! ✔️
One option is to setup an | ||
[external cache](/doc/use-cases/shared-development-server#configure-the-external-shared-cache) | ||
in a location that can handle the data. Another is to use the `--to-remote` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need a full to-cache example in import-url
(like in https://dvc.org/doc/command-reference/add#example-transfer-to-the-cache).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import-url
doesn't have the to-cache
ability, but rather work on its own (like you just import an URL with it and it puts it to your cache, but not in a chunked way).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point. But then maybe we should explain about the chunking (transferring) a bit more... I'll review again ⌛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But with --to-cache
the chinked transfer does happen, right @isidentical ? Just double checking. Already updated in c393212, PTAL.
@jorgeorpinel please split this into 3-4 PRs. It has too many things at once. Makes it hard to review. |
One option is to setup an | ||
[external cache](/doc/use-cases/shared-development-server#configure-the-external-shared-cache) | ||
in a location that can handle the data. Another is to use the `--to-remote` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import-url
doesn't have the to-cache
ability, but rather work on its own (like you just import an URL with it and it puts it to your cache, but not in a chunked way).
OK @shcheklein sorry about that. I removed the changes to |
@shcheklein on the example titles, I changed them again after thinking about it:
Cc @isidentical @dberenbaum in case you have ideas 🙂 |
Related:
Clo/ses config: incorrect system config path #2032document plots diff/show --open flag #2293Addresses Example for dvc add --to-remote #2172 (review)
Make ref: get/import/list updates #2317 reviewable when this is merged.