Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start: more Windows (Cmd) blocks #3326

Merged
merged 1 commit into from
Apr 5, 2022
Merged

start: more Windows (Cmd) blocks #3326

merged 1 commit into from
Apr 5, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Mar 2, 2022 •
edited
Loading

@jorgeorpinel jorgeorpinel self-assigned this Mar 2, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-start-windows-c-6or1mi March 2, 2022 19:49 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review March 30, 2022 08:32
@jorgeorpinel jorgeorpinel requested a review from iesahin March 30, 2022 08:32
@iesahin
Copy link
Contributor

iesahin commented Mar 30, 2022

Our statistics show we have very few Windows cmd users, anyone who's interested in DVC is using it on WSL probably. I think we can deprioritize this.

@jorgeorpinel
Copy link
Contributor Author

@iesahin this fixes existing Windows tabs in https://dvc.org/doc/start/data-and-model-versioning, please approve/merge and we can figure out whether to remove them later. That's a discussion for #3311

@jorgeorpinel jorgeorpinel requested review from iesahin and removed request for iesahin March 30, 2022 20:06
@jorgeorpinel jorgeorpinel mentioned this pull request Mar 30, 2022
Closed
5 tasks
iesahin
iesahin approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@iesahin iesahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@iesahin iesahin merged commit 9299f0f into master Apr 5, 2022
@iesahin iesahin deleted the start/windows-cmd branch April 5, 2022 16:05
iesahin pushed a commit that referenced this pull request Apr 11, 2022
@jorgeorpinel @iesahin
start: fix prev. Windows (Cmd) blocks (#3326)
eb52e65
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iesahin iesahin iesahin approved these changes

Assignees

@jorgeorpinel jorgeorpinel

Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @iesahin @shcheklein