Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvclive: Updates for "DVCLive only" experiments #4162

Merged
merged 22 commits into from
Dec 15, 2022
Merged

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Dec 5, 2022

@daavoo daavoo requested a review from dberenbaum December 5, 2022 18:28
@daavoo daavoo self-assigned this Dec 5, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-zyj1aa December 5, 2022 18:29 Inactive
@dberenbaum dberenbaum mentioned this pull request Dec 5, 2022
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

4c74743

Link Check Report

There were no links to check!

@dberenbaum
Copy link
Contributor

Minor thing that's been bothering me playing with this: should we rename save_dvc_exp to dvc_exp_save for consistency with the CLI?

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-w6kolq December 8, 2022 17:01 Inactive
@daavoo
Copy link
Contributor Author

daavoo commented Dec 9, 2022

Minor thing that's been bothering me playing with this: should we rename save_dvc_exp to dvc_exp_save for consistency with the CLI?

No strong opinion

@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference labels Dec 9, 2022
@dberenbaum

This comment was marked as outdated.

@daavoo

This comment was marked as outdated.

@daavoo daavoo requested a review from a team as a code owner December 14, 2022 15:43
@shcheklein shcheklein had a problem deploying to dvc-org-dvclive-experim-7ppkla December 14, 2022 15:44 Failure
@daavoo daavoo changed the title dvclive: Add save_dvc_exp to API reference. dvclive: Updates for "DVCLive only" experiments Dec 14, 2022
@daavoo daavoo requested a review from dberenbaum December 14, 2022 15:44
@shcheklein shcheklein requested a deployment to dvc-org-dvclive-experim-7ppkla December 14, 2022 15:47 Abandoned
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-7ppkla December 14, 2022 15:49 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-w8idqw December 14, 2022 16:02 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-goempz December 14, 2022 16:13 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-ckqbhl December 14, 2022 16:25 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-rtu25r December 14, 2022 16:37 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 14, 2022 19:21 Inactive
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 14, 2022 19:22 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 14, 2022 19:24 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 14, 2022 19:26 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 14, 2022 19:28 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 14, 2022 19:42 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 15, 2022 00:16 Inactive
@dberenbaum
Copy link
Contributor

@daavoo PTAL and merge whenever you feel it's ready 🙏 .

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 15, 2022 07:53 Inactive
@shcheklein shcheklein had a problem deploying to dvc-org-dvclive-experim-lmzafe December 15, 2022 07:56 Failure
Co-authored-by: Restyled.io <commits@restyled.io>
@daavoo daavoo enabled auto-merge (squash) December 15, 2022 08:00
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-experim-lmzafe December 15, 2022 08:00 Inactive
@daavoo daavoo merged commit 4c74743 into main Dec 15, 2022
@daavoo daavoo deleted the dvclive-experiments branch December 15, 2022 11:47
jorgeorpinel added a commit that referenced this pull request Dec 22, 2022
@jorgeorpinel jorgeorpinel mentioned this pull request Dec 22, 2022
shcheklein pushed a commit that referenced this pull request Feb 12, 2023
* typos

Per #4162 (review)

* Restyled by prettier (#4204)

Co-authored-by: Restyled.io <commits@restyled.io>

---------

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants