Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: dvc pkg cmd ref (and other misc updates) #417

Closed
wants to merge 9 commits into from
Closed

WIP: dvc pkg cmd ref (and other misc updates) #417

wants to merge 9 commits into from

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jun 7, 2019 •
edited
Loading

Review app may be at https://dvc-org-pr-417.herokuapp.com/ (enable at CI pipeline)

Closes #385

@jorgeorpinel
Adds initial pkg and pgk-install cmd refs.
015259f 
WIP
@jorgeorpinel
Removes accidental lose empty text files
87678fa
@jorgeorpinel
Adds note on credentials to dvc remote modify and other related cmd…
7df0c64 
… refs

Per https://discordapp.com/channels/485586884165107732/485596304961962003/583696642197159946
@jorgeorpinel
Updates dvc pkg install cmd ref to current core dvc repo master beh…
b45ead5 
…avior.
@jorgeorpinel
WIP: Adds 4/6 dvc pkg subcommand ref files.
142a2d2
@jorgeorpinel
First complete version of initial 4 pkg subcommands.
2f4cb72
@jorgeorpinel
Update to first 4 pkg commads per efiop/pkgs branch
e70988c 
From upstream git@github.com:efiop/dvc.git

For #385
@jorgeorpinel
Finish all pkg file up to current dev version
0e3f11b 
(See https://github.com/efiop/dvc/tree/pkgs)

- Update a few usages in first 4 commands
- Link all commands together in their intros
- Add list, modify, and import with basic examples
- Related changes in `cache dir` and `remote modify` cmd refs

For #385
@jorgeorpinel
reset to dvc cache dir implicit link in cache cmd ref
dd14502
@jorgeorpinel jorgeorpinel mentioned this pull request Jun 7, 2019
Closed
@jorgeorpinel jorgeorpinel changed the title Pkgs WIP: dvc pkg cmd ref (and other misc updates) Jun 7, 2019
@jorgeorpinel jorgeorpinel mentioned this pull request Jun 7, 2019
Merged
@efiop
Copy link
Contributor

efiop commented Jun 21, 2019

@jorgeorpinel I'm really sorry for switching back and forth, but pkg has changed again. iterative/dvc#2160 Now there are no pkg commands at all. Regular dvc import is now dvc import-url and dvc import is now working with dvc repositories. We've also introduced dvc get that is like dvc import for dvc repostiroes(what we used to call packages), but only downloads data.

@ryokugyu
Copy link
Contributor

@efiop Recently, dvc pkg --force option is also added.

in this iterative/dvc#2142

dvc pkg is being removed?

@efiop
Copy link
Contributor

efiop commented Jun 21, 2019

@ryokugyu Yes, the feature itself got reworked and there are no more dvc pkg commands.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jun 22, 2019 •
edited
Loading

Thanks for the heads up @efiop and no worries, I haven't gotten around to this anyway (but about to).

That makes sense too, BTW. Having both import and pkg import would've been confusing.

UPDATE: I see there's also a full desc of the recent version in the desc of iterative/dvc#2160 - will follow that.

@shcheklein
Copy link
Member

@jorgeorpinel closing this in favor of #464

@shcheklein shcheklein closed this Jul 1, 2019
@jorgeorpinel jorgeorpinel deleted the pkgs branch August 15, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document dvc import and dvc get (previously pkg commands)
4 participants
@jorgeorpinel @efiop @ryokugyu @shcheklein