Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: Azure and GCP remote pages #4284

Merged
merged 30 commits into from
Feb 27, 2023
Merged

guide: Azure and GCP remote pages #4284

merged 30 commits into from
Feb 27, 2023

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 2, 2023 •
edited
Loading

@jorgeorpinel jorgeorpinel added p1-important Active priorities to deal within next sprints C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference labels Feb 2, 2023
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 2, 2023
Merged
2 tasks
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 2, 2023 08:45 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as draft February 2, 2023 08:45
@jorgeorpinel jorgeorpinel force-pushed the guide/data-mgmt/remotes-azure-gcs branch from 075a120 to fe64fa5 Compare February 2, 2023 08:47
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 2, 2023 08:47 Inactive
@github-actions

This comment was marked as resolved.

Sign in to view
@jorgeorpinel
guide: finish GCS page and
2d22d1a 
improvements to the other ones (S3, Azure)
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 2, 2023 09:18 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review February 2, 2023 09:19
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 2, 2023 09:37 Inactive
jorgeorpinel
jorgeorpinel commented Feb 2, 2023
View reviewed changes
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change summary:

content/docs/user-guide/data-management/remote-storage/amazon-s3.md Outdated
Comment on lines 1 to 5
# Amazon S3

<!--
## Amazon S3
-->
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small updates to this file to match the format improvements in the new pages.

U: The lines above are no longer new but there are some other small changes to this file.

content/docs/sidebar.json
Comment on lines +132 to +133
"azure-blob-storage",
"google-cloud-storage"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these 2!

content/docs/user-guide/data-management/remote-storage/azure-blob-storage.md Outdated
Comment on lines 4 to 10
## Microsoft Azure Blob Storage
-->

`dvc remote add` a (new) remote name and a valid [Azure Blob Storage] URL:

```cli
$ dvc remote add -d myremote azure://<mycontainer>/<path>
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these details are now removed from the remote add/modify refs.

Same for GCS

content/docs/user-guide/how-to/setup-google-drive-remote.md
Comment on lines -272 to +273
> [GC project](/doc/user-guide/how-to/setup-google-drive-remote#using-a-custom-google-cloud-project-recommended)
> as explained above.
> [GC project](#using-a-custom-google-cloud-project-recommended) as explained
> above.
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, just a quick internal link fix here for now, but this page (GDrive) would probably be next (turn the existing how-to into a regular remote config page). Or maybe Aliyun OSS is easier (similar to the ones that are done)... 🤔

@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 2, 2023 16:12 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 23, 2023 06:45 Inactive
@jorgeorpinel jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Feb 23, 2023
@jorgeorpinel
Copy link
Contributor Author

@dberenbaum thanks for taking a look earlier. Yup this was waiting for #4264, which seems close to ready. I solved conflicts and applied other changes to the template from that PR to these new pages so this one should also be readyish. PTAL when you can.

I'll try to quickly contribute the rest of types by copy/pasting this template afterwards in an effort to close #2866. Some may need being taken over by your team though. No rush though, I'll be around 🙂

Base automatically changed from guide/data-mgmt/remote-config to main February 23, 2023 18:25
@dberenbaum dberenbaum self-requested a review February 23, 2023 18:40
@jorgeorpinel jorgeorpinel removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Feb 23, 2023
@jorgeorpinel
Copy link
Contributor Author

Fixed conflicts again 👍🏼

@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 23, 2023 20:13 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 23, 2023 20:17 Inactive
jorgeorpinel added a commit that referenced this pull request Feb 25, 2023
@jorgeorpinel
link all remote types (instead of admon)
4979278 
per #4284 (review)
@restyled-io restyled-io bot mentioned this pull request Feb 25, 2023
Merged
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 25, 2023 05:09 Inactive
@jorgeorpinel jorgeorpinel force-pushed the guide/data-mgmt/remotes-azure-gcs branch from 4979278 to c3e76a6 Compare February 25, 2023 05:10
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 25, 2023 05:10 Inactive
@restyled-io @restyled-commits
Restyled by prettier (#4333)
ee479a8 
Co-authored-by: Restyled.io <commits@restyled.io>
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 26, 2023 18:38 Inactive
@jorgeorpinel
Update content/docs/user-guide/data-management/remote-storage/amazon-…
a496659 
…s3.md

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 27, 2023 15:56 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-guide-data-mgmt-k1tu8s February 27, 2023 15:58 Inactive
@dberenbaum dberenbaum merged commit e6020ba into main Feb 27, 2023
@dberenbaum dberenbaum deleted the guide/data-mgmt/remotes-azure-gcs branch February 27, 2023 18:33
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) and removed p1-important Active priorities to deal within next sprints labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein left review comments

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@jorgeorpinel jorgeorpinel

Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @dberenbaum @shcheklein