Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulleted points end with : or . #495

Merged
merged 10 commits into from
Aug 12, 2019
Merged

Conversation

dnabanita7
Copy link
Contributor

Fixes #491

@dnabanita7
Copy link
Contributor Author

https://dvc.org/doc/understanding-dvc/collaboration-issues it still has "?" at end of bulleted points. Shall I change or keep it the same. Now, all of the bulleted points end with ":" or "."

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we do this, let's first come up with a set or rules

@shcheklein shcheklein requested a review from jorgeorpinel July 22, 2019 19:02
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, thanks! There's many more bullet lists in the docs though.

Let's see if we can agree to the rules I suggested in #491 (comment) and then keep going here 🙂

static/docs/get-started/agenda.md Outdated Show resolved Hide resolved
static/docs/understanding-dvc/how-it-works.md Outdated Show resolved Hide resolved
static/docs/user-guide/dvc-file-format.md Outdated Show resolved Hide resolved
@dnabanita7
Copy link
Contributor Author

dnabanita7 commented Jul 23, 2019

The docs containing bulleted points are:

  1. changelog
    a) 0.18 : ends with colon or fullstop
    b) 0.35 : ends with colon or fullstop
  2. get-started
    a) agenda : ends with nothing
    b) configure : phrases ends with nothing
    c) example:pipelines : ends with colon
  3. user guide
    a) dvc files and directories : starts with a small letter, sentences ends with fullstop, and phrases with nothing.
    b) file format : now phrases ends with nothing
    c) contributing : ends with colon and fullstop as per required.
    d) contributing-documentation : ends with fullstop.
    e) shell-autocomplete : now phrases ends with nothing and sentences with fullstop.
    f) usage-analytics : sentences ends with fullstop and phrases with nothing.
    g) dvcignore : ends with fullstop.
  4. tutorial
    a) define-ml-pipeline : now ends with nothing.
  5. understanding-dvc
    a) collaboration issues : ends with question-mark.
    b) what-is-dvc : ends with fullstop.
    c) comparison-to-existing-technologies : ends with colon and subpoints with fullstop.
    d) resources : ends with colon and bulleted links with nothing.
  6. All options of commands-reference : all ends with fullstop

@jorgeorpinel

This comment has been minimized.

@shcheklein

This comment has been minimized.

@shcheklein

This comment has been minimized.

@dnabanita7

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@dnabanita7

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@dnabanita7

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@dnabanita7

This comment has been minimized.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see my review now @naba7 ? My bad. I think I didn't submit it before so you couldn't see it.

static/docs/get-started/agenda.md Outdated Show resolved Hide resolved
static/docs/user-guide/autocomplete.md Outdated Show resolved Hide resolved
static/docs/user-guide/autocomplete.md Outdated Show resolved Hide resolved
static/docs/understanding-dvc/related-technologies.md Outdated Show resolved Hide resolved
static/docs/understanding-dvc/related-technologies.md Outdated Show resolved Hide resolved
static/docs/user-guide/dvc-files-and-directories.md Outdated Show resolved Hide resolved
static/docs/get-started/agenda.md Show resolved Hide resolved
@jorgeorpinel

This comment has been minimized.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naba7 another thing missing here is to review all the docs. I see many files that still have bullets ending in ;, for example. Search files for regex ^\-.*\n?.*; like this:

image

@dnabanita7

This comment has been minimized.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Here are some comments on the changes.

Also, there are more bullet lists that need review outside of static/docs/commands-reference/ for example in static/docs/understanding-dvc/resources.md and at least 3 more files. Please search all of static/docs/ For example searching for this basic regex ^\-.* in all files will show you every single first-level bullet.

static/docs/commands-reference/pull.md Show resolved Hide resolved
static/docs/commands-reference/push.md Show resolved Hide resolved
static/docs/commands-reference/unprotect.md Outdated Show resolved Hide resolved
@dnabanita7

This comment has been minimized.

@shcheklein

This comment has been minimized.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes great work, thanks a lot @naba7! I hope I'm not being to demanding but here are a few last things:

  • You missed a bullet list in static/docs/user-guide/autocomplete.md (lines 46-8).
  • Several bullet lists in static/docs/user-guide/dvc-file-format.md start with lower case but I think they should start with Capital letter (not sure, please double agains check the rules we agreed).
  • The last 2 bullets of the list in static/docs/user-guide/dvc-files-and-directories.md shuold not end in period .. Please use text:
    - `.dvc/updater.lock` - lock file for `.dvc/updater`
    
    - `.dvc/lock` - lock file for the whole DVC project

Please also address the comments below:

static/docs/understanding-dvc/related-technologies.md Outdated Show resolved Hide resolved
static/docs/user-guide/contributing-documentation.md Outdated Show resolved Hide resolved
static/docs/user-guide/contributing-documentation.md Outdated Show resolved Hide resolved
static/docs/user-guide/contributing.md Outdated Show resolved Hide resolved
static/docs/user-guide/contributing.md Outdated Show resolved Hide resolved
static/docs/user-guide/contributing.md Outdated Show resolved Hide resolved
@dnabanita7
Copy link
Contributor Author

Thanks @jorgeorpinel Yes, my bad! I have changed those. Please take a look!

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done! Thanks again @naba7

@shcheklein I'm approving the changes I requested in my review.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @naba7 and @jorgeorpinel !

@shcheklein shcheklein merged commit d1b0dc7 into iterative:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax: review bullet point lists throughout docs
3 participants