-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bulleted points end with : or . #495
Conversation
https://dvc.org/doc/understanding-dvc/collaboration-issues it still has "?" at end of bulleted points. Shall I change or keep it the same. Now, all of the bulleted points end with ":" or "." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before we do this, let's first come up with a set or rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, thanks! There's many more bullet lists in the docs though.
Let's see if we can agree to the rules I suggested in #491 (comment) and then keep going here 🙂
The docs containing bulleted points are:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see my review now @naba7 ? My bad. I think I didn't submit it before so you couldn't see it.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naba7 another thing missing here is to review all the docs. I see many files that still have bullets ending in ;
, for example. Search files for regex ^\-.*\n?.*;
like this:
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Here are some comments on the changes.
Also, there are more bullet lists that need review outside of static/docs/commands-reference/
for example in static/docs/understanding-dvc/resources.md
and at least 3 more files. Please search all of static/docs/
For example searching for this basic regex ^\-.*
in all files will show you every single first-level bullet.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes great work, thanks a lot @naba7! I hope I'm not being to demanding but here are a few last things:
- You missed a bullet list in static/docs/user-guide/autocomplete.md (lines 46-8).
- Several bullet lists in static/docs/user-guide/dvc-file-format.md start with lower case but I think they should start with Capital letter (not sure, please double agains check the rules we agreed).
- The last 2 bullets of the list in static/docs/user-guide/dvc-files-and-directories.md shuold not end in period
.
. Please use text:- `.dvc/updater.lock` - lock file for `.dvc/updater` - `.dvc/lock` - lock file for the whole DVC project
Please also address the comments below:
Thanks @jorgeorpinel Yes, my bad! I have changed those. Please take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done! Thanks again @naba7
@shcheklein I'm approving the changes I requested in my review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @naba7 and @jorgeorpinel !
Fixes #491