Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp save: add target arg #5090

Merged
merged 4 commits into from
Feb 16, 2024
Merged

exp save: add target arg #5090

merged 4 commits into from
Feb 16, 2024

Conversation

dberenbaum
Copy link
Contributor

Docs PR for iterative/dvc#10243

@dberenbaum dberenbaum added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Jan 17, 2024
@dberenbaum dberenbaum requested a review from pmrowla January 17, 2024 19:54
@shcheklein shcheklein temporarily deployed to dvc-org-exp-save-target-qxzjdz January 17, 2024 19:57 Inactive
Copy link
Contributor

github-actions bot commented Jan 17, 2024

Link Check Report

There were no links to check!

[targets [targets ...]]

positional arguments:
targets Stages to save. 'dvc.yaml' by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just reading this for the first time, and not reading the initial context)

I can't come with an explanation in my head on what it does and why we need this tbh :) Probably means we need to provide a bit more context in the description and/or change the message a bit to be more explicit (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the text and added an example

@shcheklein shcheklein temporarily deployed to dvc-org-exp-save-target-qxzjdz January 18, 2024 21:05 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-exp-save-target-qxzjdz January 19, 2024 12:33 Inactive
@dberenbaum dberenbaum removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Feb 9, 2024
@shcheklein shcheklein temporarily deployed to dvc-org-exp-save-target-qxzjdz February 15, 2024 17:45 Inactive
@dberenbaum dberenbaum merged commit 297692d into main Feb 16, 2024
5 checks passed
@dberenbaum dberenbaum deleted the exp-save-target branch February 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants