-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: regular update (early August) #522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff! just a couple of minor comments to address
and reformat it in glossary.json with a ES6 template literal per #522 (comment)
project when [\`dvc init\`](/doc/commands-reference/init) is run, and | ||
[DVC-files](/doc/user-guide/dvc-file-format) are created in it. It\s typically | ||
also a Git repository. | ||
` |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your question is whether the linter will fix lines that go over 80 chars, no. Neither with the previous or with this format does it fix them, neither with the hook nor run manually 🙁. It seems to leave strings alone.
Is that another issue to report to Aman?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can def check if it's possible to configure it to fix them. In any case, I don't mind the format you suggested, its' def easier to support manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @algomaster99 what do you think? (about pretty-quick
being able to warp strings in js files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks a bit strange, but let's try
Applied new format to all glossary entries in 8781a71
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I wish haha... I have lots of changes after reviewing the usage of the term "workspace" per a comment somewhere in this PR BUT I just realized that should go in it's own PR! So I saved that work separately and just pushed changes for the pending comments above. Please check @shcheklein (:
|
so diffs and file searches don't find this page when searching for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🎉 !
No description provided.