Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier formatter on all markdown files #530

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

algomaster99
Copy link
Contributor

@algomaster99 algomaster99 commented Aug 7, 2019

No description provided.

@shcheklein shcheklein merged commit 2375025 into master Aug 7, 2019
@shcheklein
Copy link
Member

@algomaster99 thanks!

@@ -127,16 +127,16 @@ The command above creates an <abbr>import stage</abbr> specified in DVC-file
### Expand to see resulting DVC-file

```yaml
...
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug.

@@ -167,18 +167,18 @@ dependency is specified.
### Expand to see resulting DVC-file

```yaml
...
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Aug 8, 2019

@algomaster99 I know this has been merged but see the comments above. That's another problem we currently have with prettier... Can you please undo those 2 changes in a new PR? (Commit them with git commit -n to avoid the Git hook) I already have a PR open and its under review otherwise I would've just done it already.

Then let's address the bug separately? Created #532 for you 😬

@jorgeorpinel
Copy link
Contributor

Actually never mind, I just opened PR #533 from a new hotfix branch so let's just go straight to trying to fix the bug (#532) please.

@shcheklein shcheklein deleted the format-md-files branch October 22, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants