-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd ref: remove unnecessary indices? #903
Conversation
Actually, on this @shcheklein what about my #727 (comment) about cmd ref indices?
Removing them would mean that the first subcommand opens by default though. For cache -> cache/dir (good), for metrics and remote -> */add, and for pipeline -> pipeline/list |
@jorgeorpinel hmm ... I think they are valuable. Not matter what, but |
Yes, they have valuable content explaining what the concepts are (cache, metrics, pipeline, remote). My point is that such content probably doesn't belong in the command reference and we can move it to a new user-guide: "Basic Concepts" (per #550) – and once that is done, it won't make sense to keep these indices. Should they just be a short list of links to their subcommands? Or remove completely and let the first one load. I think at least for |
@jorgeorpinel |
This comment has been minimized.
This comment has been minimized.
Ah yes good point. Didn't think about that. So we definitely need the indices. OK! This PR is now officially reviewable! p.s. but please note that I've extracted the discussion about moving concepts explanations out of the cmd ref to #550 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 😎
Blocked by #891Closes #727