Reduce nested ifs in find_pager

iterative · Dec 1, 2019 · a6a3cbc · a6a3cbc
1 parent 3e163f1
commit a6a3cbc
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/dvc/dagascii.py b/dvc/dagascii.py
@@ -37,20 +37,19 @@
 
 
 def find_pager():
-    if sys.stdout.isatty():
-        if is_exec_found(DEFAULT_PAGER):
-            pager_cmd = os.getenv(DVC_PAGER, DEFAULT_PAGER_FORMATTED)
+    if not sys.stdout.isatty():
+        return pydoc.plainpager
 
-            def less_pager(text):
-                return pydoc.tempfilepager(pydoc.plain(text), pager_cmd)
+    if is_exec_found(DEFAULT_PAGER):
+        pager_cmd = os.getenv(DVC_PAGER, DEFAULT_PAGER_FORMATTED)
 
-            pager = less_pager
-        else:
-            logger.info(boxify(DVC_PAGER_INFO, border_color="yellow"))
-            pager = pydoc.plainpager
-    else:
-        pager = pydoc.plainpager
-    return pager
+        def less_pager(text):
+            return pydoc.tempfilepager(pydoc.plain(text), pager_cmd)
+
+        return less_pager
+
+    logger.info(boxify(DVC_PAGER_INFO, border_color="yellow"))
+    return pydoc.plainpager
 
 
 class VertexViewer(object):