Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a lock for the dvc root command #1260

Closed
villasv opened this issue Oct 23, 2018 · 3 comments
Closed

Don't require a lock for the dvc root command #1260

villasv opened this issue Oct 23, 2018 · 3 comments

Comments

@villasv
Copy link
Contributor

villasv commented Oct 23, 2018

Is there any way that the dvc root would change in the middle of some dvc command that acquired lock? If not, I think dvc root could simply skip acquiring a lock so it can be used freely.

efiop added a commit to efiop/dvc that referenced this issue Oct 23, 2018
Fixes iterative#1260

Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
@efiop
Copy link
Contributor

efiop commented Oct 23, 2018

Good point! Could you please also share how you use dvc root in parallel with other dvc commands, so we are on the same page?

@villasv
Copy link
Contributor Author

villasv commented Oct 23, 2018

I ran into this because I've been experimenting with self-reporting data pipelines, and that diff script I mentioned in #770 plays a role on this. At first, it couldn't be used inside a dvc run because it will issue a dvc root as subprocess.

I've worked around that using git rev-parse --show-toplevel, but that only works because I assume the git root and dvc root to be the same.

@efiop
Copy link
Contributor

efiop commented Oct 23, 2018

Got it. Thank you! Patch is going to be ready for merge in ~10 minutes or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants