Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shfmt hooks to format shell scripts #2834

Closed
efiop opened this issue Nov 22, 2019 · 0 comments · Fixed by #3263
Closed

add shfmt hooks to format shell scripts #2834

efiop opened this issue Nov 22, 2019 · 0 comments · Fixed by #3263
Assignees
@casperdcl
Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint

Comments

@efiop
Copy link
Contributor

efiop commented Nov 22, 2019

Our shell scripts are all over the place, it would be nice to set a specific coding style and enforce it, same as we do with black for python. https://github.com/mvdan/sh#shfmt has some hooks for pre-commit too, and restyled.io has that too.
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Nov 22, 2019
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Nov 22, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 22, 2019
@efiop efiop added the enhancement Enhances DVC label Nov 22, 2019
@weekly-digest weekly-digest bot mentioned this issue Nov 24, 2019
Closed
@casperdcl casperdcl mentioned this issue Dec 17, 2019
Closed
casperdcl added a commit to casperdcl/dvc that referenced this issue Jan 30, 2020
@casperdcl
lint: run shfmt
2e79ce3 
Related to iterative#2834 and iterative#2969.
@casperdcl casperdcl mentioned this issue Jan 30, 2020
Merged
6 tasks
@casperdcl casperdcl self-assigned this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lint:beautysh pre-commit hook casperdcl/dvc
2 participants
@efiop @casperdcl