-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp show
: Include data files.
#6434
Comments
+1 on this. I'll be important for VS Code. On a separate note. We haven't touched source files in the Studio yet, but it would be great to have signal in the table from which you can see that there are changes to the source files between experiments. |
What should the table actually show? I don't think actually including a list of changed files in the CLI table is feasible due to the size constraints. So should it just be a true/false column to note that there is a change to data files (so users know they should check the changes with |
But if we use |
For experiments in the table it would have to be the diff between the experiment and the original baseline git commit (not the diff of one experiment to another experiment) To get the difference between two experiments you would just have to use |
Any source files or just source files that are |
What is meaningful info to show about data files? Just whether they have changed from the baseline commit? Size? Number of files? Maybe there is some tag/label/metadata that would be helpful? Also, what files should be included (dependencies, outputs, dvc-tracked files, all files)?
If we add data files to the |
I would say just a binary signal that some sources have changed is a good start.
My take (from Studio experience) - inputs (datasets) is the most important part. Les so intermediate, etc. We can start with datasets only if want to keep the table sane.
Good question. I think some signal that data has changes is enough (we highlight values in Studio with a special dot icon or something like this). Values - we could do size to start. In Studio users can switch between those. |
Show the same thing in |
Another idea here is to encourage use of the |
In addition, we could show the |
dvc exp show
: Include data files.exp show
: Include data files.
Related #6548 |
But the problem is that as we didn't change the |
I was thinking that users might update the description when they make changes, like |
Only support for |
Use `repo.index.deps` to collect dependencies associated with each experiment. Closes #6434
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Pre-requisite for #6434 Pre-requisite for #7080
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Pre-requisite for #6434 Pre-requisite for #7080
Use `repo.index.deps` to collect dependencies associated with each experiment. Closes #6434
Use `repo.index.deps` to collect dependencies associated with each experiment. Closes #6434
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Pre-requisite for #6434 Pre-requisite for #7080
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Pre-requisite for #6434 Pre-requisite for #7080
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Pre-requisite for #6434 Pre-requisite for #7080
Use `repo.index.deps` to collect dependencies associated with each experiment. Closes #6434
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Closes #7080 Pre-requisite for #6434
Use `repo.index.deps` to collect dependencies associated with each experiment. Closes #6434
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Closes #7080 Pre-requisite for #6434
Removed `--include-metrics` / `--include-params` and `--exclude-metrics` / `--exclude-params`. Removed `--no-timestamp` . Can be done by `--drop Created`. `--drop` and `--keep` operate directly on the table columns. `--keep` does not perform any filtering. It's only used to specify columns to keep despite the other filtering. For example `--only-changed --keep foo` will prevent `foo` from being removed by `--only-changed`. Another example, `--drop train.* --keep train.dropout` will remove all columns matching `train.*` except for `train.dropout`. Closes #7079 Closes #7080 Pre-requisite for #6434
If an user modifies data files in between
dvc exp run
calls, the change is not reflected in the table generated bydvc exp show
.In Studio users can view information of the data files associated to each
experiment
. I think it would be nice to include similar information in the table generated bydvc exp show
.Ideally, the feature would have the same options available for
metrics
andparams
(i.e.--include-files
/--exclude-files
).The text was updated successfully, but these errors were encountered: