Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp save: use -m for --message short option #10005

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Oct 9, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™


Closes #10004

This PR matches the short option for --message across exp run &exp save.

Docs change at iterative/dvc.org#4905

@mattseddon mattseddon changed the title exp save: use -m for --message short option exp save: use -m for --message short option Oct 9, 2023
@mattseddon mattseddon marked this pull request as ready for review October 9, 2023 08:35
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests βœ…

Files Coverage Ξ”
dvc/commands/experiments/exec_run.py 100.00% <ΓΈ> (ΓΈ)
dvc/commands/experiments/save.py 82.14% <ΓΈ> (ΓΈ)
tests/unit/command/test_experiments.py 100.00% <100.00%> (ΓΈ)

πŸ“’ Thoughts on this report? Let us know!.

@dberenbaum dberenbaum merged commit 37a4a36 into iterative:main Oct 9, 2023
@mattseddon mattseddon deleted the fix-10004 branch October 9, 2023 18:27
@@ -49,7 +49,7 @@ def add_parser(experiments_subparsers, parent_parser):
),
)
exec_run_parser.add_argument(
"-M",
"-m",
Copy link
Contributor

@efiop efiop Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should've added aliases=["-M"] to be graceful (though considering that there was a mismatch in docs maybe this hasn't been used all that much anyway yet) I'll add it in a separate PR.

#10006

efiop added a commit to efiop/dvc that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/dvc that referenced this pull request Oct 10, 2023
efiop added a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp save: Short option for --message is -M, but for dvc exp run it is -m
3 participants