Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp_url: gitignore during to_remote op #10218

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

dberenbaum
Copy link
Collaborator

Fixes #10217

@dberenbaum dberenbaum requested a review from a team January 3, 2024 12:32
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe008d9) 90.48% compared to head (b6089fb) 90.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10218   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files         499      499           
  Lines       37991    37994    +3     
  Branches     5521     5521           
=======================================
+ Hits        34376    34379    +3     
  Misses       2971     2971           
  Partials      644      644           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@efiop efiop merged commit bf5fe95 into main Jan 3, 2024
24 checks passed
@efiop efiop deleted the imp-url-to-remote-gitignore branch January 3, 2024 14:12
@efiop efiop added the bugfix fixes bug label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc import-url --to-remote: no entry added to .gitignore
2 participants