Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: handle missing/modified imports #10220

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fetch: handle missing/modified imports #10220

merged 1 commit into from
Jan 25, 2024

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jan 4, 2024

No description provided.

@efiop efiop force-pushed the test-pull-partial-import branch from cf6f543 to 97689cc Compare January 5, 2024 13:59
@efiop efiop force-pushed the test-pull-partial-import branch from 97689cc to ecc01dc Compare January 13, 2024 00:34
@efiop efiop force-pushed the test-pull-partial-import branch 3 times, most recently from 703140b to b218e3d Compare January 24, 2024 04:30
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (20edd72) 90.49% compared to head (8e9ca24) 90.49%.

Files Patch % Lines
dvc/fs/dvc.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10220   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         493      493           
  Lines       37643    37665   +22     
  Branches     5457     5461    +4     
=======================================
+ Hits        34064    34084   +20     
- Misses       2953     2954    +1     
- Partials      626      627    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop force-pushed the test-pull-partial-import branch 2 times, most recently from d0d1cd1 to 74a277e Compare January 25, 2024 11:28
@efiop efiop force-pushed the test-pull-partial-import branch from 74a277e to 8e9ca24 Compare January 25, 2024 11:46
@efiop efiop changed the title tests: pull after imp-url no-download fetch: handle missing/modified imports Jan 25, 2024
@efiop efiop merged commit df5b582 into main Jan 25, 2024
24 checks passed
@efiop efiop deleted the test-pull-partial-import branch January 25, 2024 16:34
BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
tests: pull after imp-url no-download

Co-authored-by: dberenbaum <dave@iterative.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant