Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: drop dbt implementation #10222

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jan 5, 2024

No description provided.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (0100c14) 90.42% compared to head (4de69ef) 90.47%.

Files Patch % Lines
dvc/commands/imp_db.py 20.00% 12 Missing ⚠️
dvc/database.py 85.89% 10 Missing and 1 partial ⚠️
dvc/dependency/db.py 88.88% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10222      +/-   ##
==========================================
+ Coverage   90.42%   90.47%   +0.05%     
==========================================
  Files         499      492       -7     
  Lines       38056    37614     -442     
  Branches     5531     5451      -80     
==========================================
- Hits        34413    34033     -380     
+ Misses       2997     2953      -44     
+ Partials      646      628      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit 426a714 into iterative:main Jan 5, 2024
23 of 24 checks passed
@skshetry skshetry deleted the remove-dbt branch January 5, 2024 13:31
BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
* remove dbt implementation in the database

* lazy load client

* fixup

* fixup

* fix server side cursors

* use exec_driver_sql for testing connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant