Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp show: output executor info for successful exps when available #10239

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Jan 16, 2024

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Should close #9425
related: #9442

For sucessfully run queued experiments, dvc exp show --json will now include executor info if it's still available (i.e. logs haven't been removed with dvc queue remove)

"experiments": [
      {
        "revs": [
          {
            "rev": "cb9a2cbf153a84f29d6c0b811e3b834054931459",
            "name": "timid-pear",
            "data": {
              ...
              },
              "deps": {
                ...
                }
              },
              "outs": {
                ...
              },
              "meta": {}
            },
            "error": null,
            "experiments": null
          }
        ],
        "executor": {
          "state": "success",
          "name": "dvc-task",
          "local": {
            "root": null,
            "log": "/Users/pmrowla/git/example-get-started/.dvc/tmp/exps/run/af02dc1c0758c910a7c643194e5ba3f2687f463f/af02dc1c0758c910a7c643194e5ba3f2687f463f.out",
            "pid": 16615,
            "returncode": 0,
            "task_id": "af02dc1c0758c910a7c643194e5ba3f2687f463f"
          }
        },
        "name": "timid-pear"
      },
...

note that:

  • pid is listed but will no longer be valid since the run finished
  • root is unavailable since the tempdir used for execution is removed on exp completion (but the logs are available and stored in a separate location)

executor will still be null for successful workspace and --temp runs since we do not preserve any executor state or logs in those cases (handling logs for these cases will be done separately, but once those are available they will work the same as the dvc-task queued exps here)

@pmrowla pmrowla self-assigned this Jan 16, 2024
@pmrowla pmrowla requested a review from mattseddon January 16, 2024 07:24
@pmrowla pmrowla marked this pull request as ready for review January 16, 2024 07:28
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (df5b582) 90.49% compared to head (9c55949) 90.47%.

Files Patch % Lines
dvc/repo/experiments/queue/celery.py 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10239      +/-   ##
==========================================
- Coverage   90.49%   90.47%   -0.03%     
==========================================
  Files         493      493              
  Lines       37665    37680      +15     
  Branches     5461     5465       +4     
==========================================
+ Hits        34084    34090       +6     
- Misses       2954     2962       +8     
- Partials      627      628       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works πŸ‘πŸ»:

Screen.Recording.2024-01-17.at.3.10.04.pm.mov

Sorry to be that guy but... any reason there are no tests?

@pmrowla
Copy link
Contributor Author

pmrowla commented Jan 17, 2024

The underlying code for collecting all of this info is already tested (this PR doesn't actually do anything new other than exposing it in the output)

@dberenbaum
Copy link
Collaborator

@pmrowla Is it ready to merge?

@pmrowla pmrowla force-pushed the exp-show-success-executor branch from eef228f to 9c55949 Compare January 29, 2024 06:00
@pmrowla pmrowla merged commit 196c1c7 into iterative:main Jan 29, 2024
24 checks passed
@pmrowla pmrowla deleted the exp-show-success-executor branch January 29, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp show: provide executor information for finished experiments
3 participants