-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Prevent strings from wrapping in .yaml for a proper round-trip #10669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent strings from wrapping in .yaml for a proper round-trip #10669
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10669 +/- ##
==========================================
+ Coverage 90.68% 91.07% +0.39%
==========================================
Files 504 504
Lines 39795 39932 +137
Branches 3141 3157 +16
==========================================
+ Hits 36087 36367 +280
+ Misses 3042 2938 -104
+ Partials 666 627 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just to give an update, I have been using this branch at works since and encountered no issues. |
@skshetry can we merge this? |
See #10668 (comment). |
@janpawlowskiof, thank you for contributing to DVC. It looks like this behavior was introduced in ruamel-yaml #10668 has seen very little activity, so it seems to be a rare occurrence. Adjusting I'll keep you updated on the issue, and I'm going to close this for the time being. |
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Solve for #10668
This issue and solution was somewhat mentioned in #9397
Cheers!