Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get: no relpath on output not found #2435

Merged
merged 3 commits into from Sep 6, 2019
Merged

get: no relpath on output not found #2435

merged 3 commits into from Sep 6, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2019

Improve error message.

Close #2430

@ghost ghost requested a review from efiop August 24, 2019 18:52

msg = "unable to find DVC-file with output '{}'".format(relpath(out))

def is_dvc_repo(out):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify what is going on? This looks really obscure.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 190fbaa into iterative:master Sep 6, 2019
@ghost ghost deleted the improve-error-message-on-get branch September 7, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get: relpath in error message for inexistent path is not nice
1 participant