Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: introduce --always-changed #2479

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Sep 9, 2019

This is an extension of our callback stages (no deps, so always
considered as changed) for stages with dependencies, so that these
stages could be used properly in the middle of the DAG. See attached
issue for more info.

Related to #2378

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.

Doc PR is coming soon.


@efiop efiop changed the title run: introduce --always-changed [WIP] run: introduce --always-changed Sep 9, 2019
This is an extension of our callback stages (no deps, so always
considered as changed) for stages with dependencies, so that these
stages could be used properly in the middle of the DAG. See attached
issue for more info.

Related to iterative#2378
@efiop efiop changed the title [WIP] run: introduce --always-changed run: introduce --always-changed Sep 9, 2019
Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should mention in docs that locked overrides always_changed

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@efiop efiop merged commit a529f7d into iterative:master Sep 9, 2019
@efiop efiop deleted the always_reproduce branch September 9, 2019 16:45
efiop added a commit to efiop/dvc.org that referenced this pull request Sep 9, 2019
efiop added a commit to efiop/dvc.org that referenced this pull request Sep 9, 2019
efiop added a commit to efiop/dvc.org that referenced this pull request Sep 9, 2019
efiop added a commit to efiop/dvc.org that referenced this pull request Sep 9, 2019
efiop added a commit to efiop/dvc.org that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants