Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing while pulling imported directories #2692

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Conversation

shcheklein
Copy link
Member

Fixes #2684

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


@shcheklein shcheklein requested a review from a user October 30, 2019 00:32
dvc/repo/fetch.py Outdated Show resolved Hide resolved
@efiop
Copy link
Contributor

efiop commented Oct 30, 2019

@shcheklein Please don't put fix-2684 - to the PR name, issue reference in the PR comment is enough, no need to make the PR name even longer. Same with commit name.

@shcheklein shcheklein changed the title fix-2684 - failing while pulling imported directories failing while pulling imported directories Oct 30, 2019
@shcheklein
Copy link
Member Author

PR name - not sure why it matters at all.
commit name - if it's not in the description information is lost after merge, right? (commit <--> ticket)?

@shcheklein shcheklein requested a review from efiop October 30, 2019 14:34
@efiop
Copy link
Contributor

efiop commented Oct 30, 2019

PR name - not sure why it matters at all.

because PR name is limited :) The shorter the better.

commit name - if it's not in the description information is lost after merge, right? (commit <--> ticket)?

Not really, it still stays in the squashed commit message.

tests/func/test_import.py Outdated Show resolved Hide resolved
Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 2ec0aa0 into iterative:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on first-time dvc pull
2 participants