dvc: revert checkout to be silly and fast, relink on dvc add though #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5ec1d27. Save tests to try make them work, and `_get_cache_type()` to be used later.
Fix iterative#2016 without all the complications of iterative#2358.
ghost
reviewed
Dec 3, 2019
ghost
approved these changes
Dec 3, 2019
pared
reviewed
Dec 4, 2019
pared
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2492, reverts #2358 and fixes #2016 other way.
So now:
dvc checkoutdoes not relink unless out is changeddvc add/runalways relinks, but slow unneeded copy is not madeI left @pared checkout tests and marked them as skipped to be reused later to test
--relink.