Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get: copy edits aroud --show-url, "dvc", et al. #3220

Merged
merged 6 commits into from
Jan 23, 2020
Merged

get: copy edits aroud --show-url, "dvc", et al. #3220

merged 6 commits into from
Jan 23, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jan 23, 2020

Per #3156 (review)

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Docs PR already exists: iterative/dvc.org/pull/926

other misc. language improvements
@jorgeorpinel jorgeorpinel marked this pull request as ready for review January 23, 2020 06:36
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jan 23, 2020

The last commit came out of #3156 (review) but I didn't expect how many instances of the term "dvc" (lower case) in strings there are (grep /".*dvc/). I reviewed through the dvc/command/ dir so far. Depending on reaction to this PR, I may go over the rest of the code base when I have a chance.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ thanks @jorgeorpinel

@jorgeorpinel jorgeorpinel changed the title get: copy edits aroud --show-url get: copy edits aroud --show-url, "dvc", et al. Jan 23, 2020
@efiop efiop merged commit da6399d into iterative:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants