remote: verify cache exists on dir checksum #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Jan 23, 2020
| @@ -233,6 +241,9 @@ def _collect_dir(self, path_info): | |||
| return sorted(result, key=itemgetter(self.PARAM_RELPATH)) | |||
|
|
|||
| def get_dir_checksum(self, path_info): | |||
| if not self.cache: | |||
There was a problem hiding this comment.
Would it make sense to unify it somehow with https://github.com/iterative/dvc/blob/master/dvc/output/base.py#L102 ?
There was a problem hiding this comment.
@efiop Do you mean, using same error in both places, or using self.REMOTE.scheme to point user in right direction?
pared
force-pushed
the
2647_no_cache_external_dir
branch
from
29e55c8 to
db0e699
Compare
efiop
reviewed
Jan 24, 2020
dvc/exceptions.py
Outdated
| def __init__(self, scheme): | ||
| super().__init__( | ||
| "Remote cache for '{}' remote is required to perform this " | ||
| "operation".format(scheme) |
There was a problem hiding this comment.
Could we add something helpful or add a link to docs?
There was a problem hiding this comment.
Also "this operation" is not very clear. Maybe we could include path too to be more precise about what path has caused this exception?
pared
force-pushed
the
2647_no_cache_external_dir
branch
2 times, most recently
from
3d63fc0 to
4c7b31d
Compare
pared
force-pushed
the
2647_no_cache_external_dir
branch
from
4c7b31d to
6557fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #2647