-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff: reimplement interface and tests from scratch #3229
Conversation
@MrOutis What is the point of these tests if they are all commented out and TODos? |
I think the ticket was saying that we shouldn't show checksums by default. Wouldn't bother with introducing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool so far.
* OSError -> FileNotFoundError * Make `a_ref` optional * Use absolute imports for unrelated packages * Relpath: `str(output.path_info)` -> `str(output)` * `a_ref` defaults to `HEAD` at the signature and parser level
@Suor, could you please take a look again? I did quite a lot of changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrOutis please check the tests, looks like there are some dict ordering issues. |
@efiop , doing it right now |
Co-authored-by: @jorgeorpinel <jorge@opinel.com>
@Suor, I changed the diff logic to use dicts
What's the fastest way to see if this is released or get notified when it is? I don't think it's included in |
Close: #2982, #2998, #2999, #1893, #2372
Related: #770
--target
option.--checksum
option is provided.--show-json
option is given.dvc diff
when there's no cache available.Questions:
--recursive
option to explicitly recurse directory outputs?renamed
files?