Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check that no remote backend modules are loaded by default #3400

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Feb 25, 2020

We had this missed out repeatedly over time, so I added a check that we don't import any remote related deps on initial load.

Examples of related issues are #3399 and #2445.

@Suor
Copy link
Contributor Author

Suor commented Feb 25, 2020

BTW, the test should fail until #3399 lands.

@shcheklein
Copy link
Member

@Suor could you please rebase/merge?

@efiop efiop requested a review from pared February 26, 2020 01:01
@Suor Suor force-pushed the remote-imports branch 2 times, most recently from bf2006b to 5be238f Compare February 26, 2020 04:29
@Suor
Copy link
Contributor Author

Suor commented Feb 26, 2020

Rebased

tests/unit/test_imports.py Outdated Show resolved Hide resolved
@Suor
Copy link
Contributor Author

Suor commented Feb 27, 2020

Fixed Python 3.5

@skshetry skshetry requested a review from pared February 27, 2020 11:37
@Suor
Copy link
Contributor Author

Suor commented Feb 28, 2020

Should be ready to merge.

@efiop efiop merged commit 05cc023 into iterative:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants